fix: address code review round 2 — 9 issues (2 critical, 3 important, 4 minor)
Critical: - #2: Add _entry_lock in RiskManager to serialize concurrent entry (balance race) - #3: Add startTime to get_recent_income + record _entry_time_ms (SYNC PnL fix) Important: - #1: Add threading.Lock + _run_api() helper for thread-safe Client access - #4: Convert reset_daily to async with lock - #8: Add 24h TTL to exchange_info_cache Minor: - #7: Remove duplicate Indicators creation in _open_position (use ATR directly) - #11: Add input validation for LEVERAGE, MARGIN ratios, ML_THRESHOLD - #12: Replace hardcoded corr[0]/corr[1] with dict-based dynamic access - #14: Add fillna(0.0) to LightGBM path for NaN consistency with ONNX Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
2
main.py
2
main.py
@@ -19,7 +19,7 @@ async def _daily_reset_loop(risk: RiskManager):
|
||||
hour=0, minute=0, second=0, microsecond=0,
|
||||
)
|
||||
await asyncio.sleep((next_midnight - now).total_seconds())
|
||||
risk.reset_daily()
|
||||
await risk.reset_daily()
|
||||
|
||||
|
||||
async def _graceful_shutdown(bots: list[TradingBot], tasks: list[asyncio.Task]):
|
||||
|
||||
Reference in New Issue
Block a user